Issue 20224003: Implement IsolateMirror.

Issue 20224003: Implement IsolateMirror. (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
ngeoffray, kustermann

CC:
reviews_dartlang.org, rmacnak, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement IsolateMirror. R=kustermann@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25516

Patch Set 2 : Address comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -8 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	3 chunks	+18 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	6 chunks	+32 lines, -6 lines	0 comments	Download
M	dart/tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/lib/mirrors/local_isolate_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://codereview.chromium.org/20224003/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/20224003/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3983 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3983: var isRoot = !!data[4]; I guess this double ...

7 years, 5 months ago (2013-07-25 14:56:45 UTC) #3

ahe

PTAL https://codereview.chromium.org/20224003/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/20224003/diff/2001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3983 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3983: var isRoot = !!data[4]; On 2013/07/25 14:56:45, kustermann ...

7 years, 5 months ago (2013-07-25 18:01:01 UTC) #4

ahe

7 years, 5 months ago (2013-07-26 10:12:02 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 manually as r25516 (presubmit successful).

Expand Messages | Collapse Messages