Issue 202193002: pkg/dartdoc: moving files around, fix library names

Issue 202193002: pkg/dartdoc: moving files around, fix library names (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/dartdoc: moving files around, fix library names R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=33756

Patch Set 2 : fixed year #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -244 lines)			Patch
D	pkg/docgen/lib/dart2yaml.dart	View		1 chunk	+0 lines, -84 lines	0 comments	Download
M	pkg/docgen/lib/docgen.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
D	pkg/docgen/lib/dottedLibraryName.dart	View		1 chunk	+0 lines, -34 lines	0 comments	Download
A +	pkg/docgen/lib/src/dart2yaml.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/docgen/lib/src/io.dart	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	pkg/docgen/lib/src/mdn.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/docgen/lib/src/models.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/docgen/lib/src/utils.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/docgen/test/generate_json_test.dart	View		3 chunks	+24 lines, -16 lines	0 comments	Download
A +	pkg/docgen/test/multi_library_code/lib/dottedLibraryName.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	pkg/docgen/test/multi_library_code/lib/temp.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	pkg/docgen/test/multi_library_code/lib/temp2.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	pkg/docgen/test/multi_library_code/lib/temp3.dart	View		1 chunk	+0 lines, -13 lines	0 comments	Download
A +	pkg/docgen/test/multi_library_code/lib/test_lib.dart	View		1 chunk	+6 lines, -5 lines	0 comments	Download
A	pkg/docgen/test/multi_library_code/lib/test_lib_bar.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	pkg/docgen/test/multi_library_code/lib/test_lib_foo.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/docgen/test/multi_library_test.dart	View		5 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

lgtm Other than copyright dates, lgtm. https://codereview.chromium.org/202193002/diff/1/pkg/docgen/lib/src/io.dart File pkg/docgen/lib/src/io.dart (right): https://codereview.chromium.org/202193002/diff/1/pkg/docgen/lib/src/io.dart#newcode1 pkg/docgen/lib/src/io.dart:1: // Copyright (c) ...

6 years, 9 months ago (2014-03-17 17:31:56 UTC) #2

kevmoo

https://codereview.chromium.org/202193002/diff/1/pkg/docgen/lib/src/io.dart File pkg/docgen/lib/src/io.dart (right): https://codereview.chromium.org/202193002/diff/1/pkg/docgen/lib/src/io.dart#newcode1 pkg/docgen/lib/src/io.dart:1: // Copyright (c) 2013, the Dart project authors. Please ...

6 years, 9 months ago (2014-03-17 17:45:53 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-17 17:46:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33756 (presubmit successful).

Expand Messages | Collapse Messages