Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 20218003: Compare against Symbol instead of calling MirrorSystem.getName() (Closed)

Created:
7 years, 5 months ago by Michael Lippautz (Google)
Modified:
7 years, 5 months ago
Reviewers:
ahe, rmacnak
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M tests/lib/mirrors/method_mirror_returntype_test.dart View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Lippautz (Google)
7 years, 5 months ago (2013-07-25 01:16:09 UTC) #1
ahe
lgtm
7 years, 5 months ago (2013-07-25 10:30:45 UTC) #2
Michael Lippautz (Google)
7 years, 5 months ago (2013-07-25 18:16:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698