Issue 20208002: Inline MethodMirror creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20208002: Inline MethodMirror creation (Closed)

Created:
7 years, 5 months ago by Michael Lippautz (Google)

Modified:
7 years, 5 months ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25499

Patch Set 2 : #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -48 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	3 chunks	+30 lines, -46 lines	2 comments	Download
M	runtime/lib/mirrors_impl.dart	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/20208002/diff/2001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/20208002/diff/2001/runtime/lib/mirrors.cc#newcode555 runtime/lib/mirrors.cc:555: HANDLESCOPE(Isolate::Current()); Is the HANDLESCOPE here needed? Do we ...

7 years, 5 months ago (2013-07-25 20:54:40 UTC) #2

Michael Lippautz (Google)

https://codereview.chromium.org/20208002/diff/2001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/20208002/diff/2001/runtime/lib/mirrors.cc#newcode555 runtime/lib/mirrors.cc:555: HANDLESCOPE(Isolate::Current()); On 2013/07/25 20:54:40, siva wrote: > Is the ...

7 years, 5 months ago (2013-07-25 21:06:38 UTC) #3

Michael Lippautz (Google)

7 years, 5 months ago (2013-07-25 21:10:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25499 (presubmit successful).

Expand Messages | Collapse Messages

Issue 20208002: Inline MethodMirror creation (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages