Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2019423002: Make PbMapMixin implement Map<String, dynamic> (Closed)

Created:
4 years, 6 months ago by kevmoo
Modified:
4 years, 6 months ago
Reviewers:
skybrian
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protobuf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make PbMapMixin implement Map<String, dynamic> A more clean way to get to strong mode R=skybrian@google.com Committed: https://github.com/dart-lang/protobuf/commit/97e5bb783f5babfd8161ec566684b71b524b1826

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/protobuf/mixins/map_mixin.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/map_mixin_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
4 years, 6 months ago (2016-05-30 16:43:20 UTC) #2
skybrian
LGTM Are you actually using this mixin? (It's meant mostly as an example.)
4 years, 6 months ago (2016-05-31 20:01:39 UTC) #3
kevmoo
Committed patchset #2 (id:20001) manually as 97e5bb783f5babfd8161ec566684b71b524b1826 (presubmit successful).
4 years, 6 months ago (2016-06-01 17:12:21 UTC) #5
kevmoo
4 years, 6 months ago (2016-06-01 17:13:32 UTC) #6
Message was sent while issue was closed. 
On 2016/05/31 20:01:39, skybrian wrote:
> LGTM
> 
> Are you actually using this mixin? (It's meant mostly as an example.)

No, but it causes strong-mode errors that would be good to avoid – it shows up
in the protobuf-plugin

Powered by Google App Engine
This is Rietveld 408576698