Replace someElement with anyElement.

Replace someElement with anyElement.
See https://code.google.com/p/dart/issues/detail?id=10189

R=seaneagan1@gmail.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25479

[gram, 2013-07-25 16:40:41]

Adding Siggy as no response yet from Sean

[Siggi Cherem (dart-lang), 2013-07-25 16:48:34]

lgtm

Is 'meta' already a dependency in the pubspec.yaml? If not, we might need to add
it.

[Sean Eagan, 2013-07-25 16:55:08]

On 2013/07/25 00:56:26, gram wrote:

lgtm

[Sean Eagan, 2013-07-25 16:55:15]

https://codereview.chromium.org/20172003/diff/3001/pkg/unittest/lib/src/itera...
File pkg/unittest/lib/src/iterable_matchers.dart (left):

https://codereview.chromium.org/20172003/diff/3001/pkg/unittest/lib/src/itera...
pkg/unittest/lib/src/iterable_matchers.dart:72: return item.any((e) =>
_matcher.matches(e, matchState));
In describe below, 'some element ' -> 'any element ' ?

[gram, 2013-07-25 17:07:05]

https://codereview.chromium.org/20172003/diff/3001/pkg/unittest/lib/src/itera...
File pkg/unittest/lib/src/iterable_matchers.dart (left):

https://codereview.chromium.org/20172003/diff/3001/pkg/unittest/lib/src/itera...
pkg/unittest/lib/src/iterable_matchers.dart:72: return item.any((e) =>
_matcher.matches(e, matchState));
On 2013/07/25 16:55:15, Sean Eagan wrote:
> In describe below, 'some element ' -> 'any element ' ?

I thought about that but IMO 'some element' reads better in the error messages;
I personally find the anyElement name less clear than someElement and we don't
need to change the message to match if it doesn't make sense. If you disagree
let me know.

To me, in English, you would typically say things like:

- you can come on any day; we will be here
- on some days it rains

and in the first case you really mean we will be here every day, so I find using
this as an assert is confusing; it suggests to me that you can 'pick any element
and the assert is true', i.e. 'the assert is true for all elements'.

[gram, 2013-07-25 17:17:01]

Committed patchset #2 manually as r25479 (presubmit successful).