Added generic information for return types.

Added generic information for return types.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25502

[Alan Knight, 2013-07-24 23:06:44]

https://codereview.chromium.org/20162005/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/20162005/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:431: */
I don't love these names. "get" is usually not providing any more information,
and "helper" likewise. What about just calling it _returnType(TypeMirror mirror)
and _typeParameters(TypeMirror mirror)?

Although that also makes me wonder why any of this is specific to return types.
Don't these apply to all types?

https://codereview.chromium.org/20162005/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:707: * A class containing properties of a return
type.
We know it's a class, what does "containing properties" mean? Something like
"Holds the name of a return type, and its generic type parameters" would be more
concrete.

[janicejl, 2013-07-25 00:29:37]

https://codereview.chromium.org/20162005/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/20162005/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:431: */
On 2013/07/24 23:06:44, Alan Knight wrote:
> I don't love these names. "get" is usually not providing any more information,
> and "helper" likewise. What about just calling it _returnType(TypeMirror
mirror)
> and _typeParameters(TypeMirror mirror)?
> 
> Although that also makes me wonder why any of this is specific to return
types.
> Don't these apply to all types?

Done. That was a good point, it was not specific to only return types. Thanks. 

Have added for variables and parameters instead of only method return types.

https://codereview.chromium.org/20162005/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:707: * A class containing properties of a return
type.
On 2013/07/24 23:06:44, Alan Knight wrote:
> We know it's a class, what does "containing properties" mean? Something like
> "Holds the name of a return type, and its generic type parameters" would be
more
> concrete.

Done.

[Emily Fortuna, 2013-07-25 17:38:08]

https://codereview.chromium.org/20162005/diff/5001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/20162005/diff/5001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:723: *                  "inner" :
can your example show an inner part, too?

[Alan Knight, 2013-07-25 17:41:43]

lgtm

[janicejl, 2013-07-25 21:39:56]

https://codereview.chromium.org/20162005/diff/5001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/20162005/diff/5001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:723: *                  "inner" :
On 2013/07/25 17:38:08, Emily Fortuna wrote:
> can your example show an inner part, too?

Done.

[janicejl, 2013-07-25 21:44:53]

Committed patchset #3 manually as r25502 (presubmit successful).