Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 20149004: [mdv] implement Node.createBinding and Node.createBindings (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -233 lines) Patch
M pkg/mdv/lib/mdv.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/mdv/lib/src/element.dart View 1 chunk +24 lines, -39 lines 1 comment Download
M pkg/mdv/lib/src/input_bindings.dart View 1 4 chunks +36 lines, -39 lines 1 comment Download
M pkg/mdv/lib/src/input_element.dart View 1 chunk +9 lines, -43 lines 0 comments Download
M pkg/mdv/lib/src/list_diff.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/mdv/lib/src/node.dart View 2 chunks +100 lines, -5 lines 1 comment Download
M pkg/mdv/lib/src/select_element.dart View 1 1 chunk +6 lines, -23 lines 0 comments Download
M pkg/mdv/lib/src/template.dart View 3 chunks +27 lines, -25 lines 0 comments Download
M pkg/mdv/lib/src/template_iterator.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/mdv/lib/src/text.dart View 1 chunk +8 lines, -29 lines 0 comments Download
M pkg/mdv/lib/src/text_area_element.dart View 1 chunk +6 lines, -19 lines 0 comments Download
M pkg/observe/lib/src/change_record.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +23 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +23 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 3 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
more progress to catching up with MDV
7 years, 5 months ago (2013-07-25 00:02:52 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/20149004/diff/1001/pkg/mdv/lib/src/element.dart File pkg/mdv/lib/src/element.dart (right): https://codereview.chromium.org/20149004/diff/1001/pkg/mdv/lib/src/element.dart#newcode45 pkg/mdv/lib/src/element.dart:45: node.xtag.attributes[property] = sanitizeBoundValue(value); should that escaping be defined ...
7 years, 5 months ago (2013-07-25 16:24:12 UTC) #2
Jennifer Messerly
7 years, 5 months ago (2013-07-25 18:01:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698