Allow SIMD types to be used on mips

Allow SIMD types to be used on mips

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25481

[Cutch, 2013-07-24 23:59:44]

This CL makes it possible to use the native C methods for Float32x4 and Uint32x4
on simmips.

Zach & Regis-

I get a crash in float32x4_shuffle_test.dart:

(gdb) run --package-root=packages --deoptimization_counter_threshold=1000
--optimization-counter-threshold=10
../../tests/lib/typed_data/float32x4_shuffle_test.dart
Starting program:
/Users/johnmccutchan/workspace/dart-repo/dart/xcodebuild/DebugSIMMIPS/dart
--package-root=packages --deoptimization_counter_threshold=1000
--optimization-counter-threshold=10
../../tests/lib/typed_data/float32x4_shuffle_test.dart
Reading symbols for shared libraries
+++++............................................................. done
/Users/johnmccutchan/workspace/dart-repo/dart/runtime/vm/assembler_mips.cc:52:
error: expected: Utils::IsInt(18, offset)

Program received signal SIGABRT, Aborted.
0x985b63ba in __kill ()
(gdb) bt
#0  0x985b63ba in __kill ()
#1  0x985b54bc in kill$UNIX2003 ()
#2  0x9849151b in abort ()
#3  0x0005386b in dart::DynamicAssertionHelper::Fail (this=0xbfffc8a0,
format=0x5a19b8 "expected: %s") at assert.cc:40
#4  0x000d8981 in dart::Assembler::EncodeBranchOffset (offset=-1073755976,
instr=0) at assembler_mips.cc:52
#5  0x0019b220 in dart::Assembler::EmitBranch (this=0xbfffd570, b=dart::BNE,
rs=dart::R25, rt=dart::R0, label=0x7b8cc44) at assembler_mips.h:1194
#6  0x003a1f5b in dart::Assembler::bne (this=0xbfffd570, rs=dart::R25,
rt=dart::R0, l=0x7b8cc44) at stub_code_mips.cc:1241
#7  0x0020873c in dart::CheckClassInstr::EmitNativeCode (this=0x125cac0,
compiler=0xbfffd4f0) at intermediate_language_mips.cc:3448
#8  0x00189e0d in dart::FlowGraphCompiler::VisitBlocks (this=0xbfffd4f0) at
flow_graph_compiler.cc:248
#9  0x00196009 in dart::FlowGraphCompiler::CompileGraph (this=0xbfffd4f0) at
flow_graph_compiler_mips.cc:1255
#10 0x0012a987 in CompileParsedFunctionHelper (parsed_function=0xbfffd9d8,
osr_id=-1, optimized=true) at compiler.cc:499
#11 0x0012ddc8 in CompileFunctionHelper (function=@0xbfffe2d8, osr_id=-1,
optimized=true) at compiler.cc:716
#12 0x0012e389 in dart::Compiler::CompileOptimizedFunction
(function=@0xbfffe750, osr_id=-1) at compiler.cc:774
#13 0x0011dece in dart::DRT_OptimizeInvokedFunction () at code_generator.cc:1483
#14 0x0037c247 in dart::Simulator::DoBreak (this=0xa33540, instr=0xa33d0c) at
simulator_mips.cc:1052
#15 0x0037c60e in dart::Simulator::DecodeSpecial (this=0xa33540, instr=0xa33d0c)
at simulator_mips.cc:1120
#16 0x0037a2a1 in dart::Simulator::InstructionDecode (this=0xa33540,
instr=0xa33d0c) at simulator_mips.cc:1737
#17 0x0037f2c6 in dart::Simulator::Execute (this=0xa33540) at
simulator_mips.cc:2046
#18 0x0037f6ba in dart::Simulator::Call (this=0xa33540, entry=14954560,
parameter0=15170496, parameter1=19231628, parameter2=19231564,
parameter3=19116544, fp_return=false, fp_args=false) at simulator_mips.cc:2147
#19 0x001392e9 in dart::IsolateRunStateManager::~IsolateRunStateManager () at
/Users/johnmccutchan/workspace/dart-repo/dart/runtime/vm/isolate.h:67
#20 0x001392e9 in dart::DartEntry::InvokeFunction (function=@0x1257364,
arguments=@0x125734c, arguments_descriptor=@0x125738c, context=@0x123b200) at
dart_entry.cc:67
#21 0x00139588 in dart::DartEntry::InvokeFunction (function=@0x1257364,
arguments=@0x125734c, arguments_descriptor=@0x125738c) at dart_entry.cc:36
#22 0x00139680 in dart::DartEntry::InvokeFunction (function=@0x1257364,
arguments=@0x125734c) at dart_entry.cc:26
#23 0x00018613 in Dart_Invoke (target=0x1256e3c, name=0x1256e40,
number_of_arguments=0, arguments=0x0) at dart_api_impl.cc:2974
#24 0x00003dcf in dart::bin::main (argc=5, argv=0xbffff9cc) at main.cc:864
#25 0x000022a5 in start ()

[zra, 2013-07-25 00:08:06]

On 2013/07/24 23:59:44, Cutch wrote:
> This CL makes it possible to use the native C methods for Float32x4 and
Uint32x4
> on simmips.
> 
> Zach & Regis-
> 
> I get a crash in float32x4_shuffle_test.dart:
> 
> (gdb) run --package-root=packages --deoptimization_counter_threshold=1000
> --optimization-counter-threshold=10
> ../../tests/lib/typed_data/float32x4_shuffle_test.dart
> Starting program:
> /Users/johnmccutchan/workspace/dart-repo/dart/xcodebuild/DebugSIMMIPS/dart
> --package-root=packages --deoptimization_counter_threshold=1000
> --optimization-counter-threshold=10
> ../../tests/lib/typed_data/float32x4_shuffle_test.dart
> Reading symbols for shared libraries
> +++++............................................................. done
> /Users/johnmccutchan/workspace/dart-repo/dart/runtime/vm/assembler_mips.cc:52:
> error: expected: Utils::IsInt(18, offset)
> 
> Program received signal SIGABRT, Aborted.
> 0x985b63ba in __kill ()
> (gdb) bt
> #0  0x985b63ba in __kill ()
> #1  0x985b54bc in kill$UNIX2003 ()
> #2  0x9849151b in abort ()
> #3  0x0005386b in dart::DynamicAssertionHelper::Fail (this=0xbfffc8a0,
> format=0x5a19b8 "expected: %s") at assert.cc:40
> #4  0x000d8981 in dart::Assembler::EncodeBranchOffset (offset=-1073755976,
> instr=0) at assembler_mips.cc:52
> #5  0x0019b220 in dart::Assembler::EmitBranch (this=0xbfffd570, b=dart::BNE,
> rs=dart::R25, rt=dart::R0, label=0x7b8cc44) at assembler_mips.h:1194
> #6  0x003a1f5b in dart::Assembler::bne (this=0xbfffd570, rs=dart::R25,
> rt=dart::R0, l=0x7b8cc44) at stub_code_mips.cc:1241
> #7  0x0020873c in dart::CheckClassInstr::EmitNativeCode (this=0x125cac0,
> compiler=0xbfffd4f0) at intermediate_language_mips.cc:3448
> #8  0x00189e0d in dart::FlowGraphCompiler::VisitBlocks (this=0xbfffd4f0) at
> flow_graph_compiler.cc:248
> #9  0x00196009 in dart::FlowGraphCompiler::CompileGraph (this=0xbfffd4f0) at
> flow_graph_compiler_mips.cc:1255
> #10 0x0012a987 in CompileParsedFunctionHelper (parsed_function=0xbfffd9d8,
> osr_id=-1, optimized=true) at compiler.cc:499
> #11 0x0012ddc8 in CompileFunctionHelper (function=@0xbfffe2d8, osr_id=-1,
> optimized=true) at compiler.cc:716
> #12 0x0012e389 in dart::Compiler::CompileOptimizedFunction
> (function=@0xbfffe750, osr_id=-1) at compiler.cc:774
> #13 0x0011dece in dart::DRT_OptimizeInvokedFunction () at
code_generator.cc:1483
> #14 0x0037c247 in dart::Simulator::DoBreak (this=0xa33540, instr=0xa33d0c) at
> simulator_mips.cc:1052
> #15 0x0037c60e in dart::Simulator::DecodeSpecial (this=0xa33540,
instr=0xa33d0c)
> at simulator_mips.cc:1120
> #16 0x0037a2a1 in dart::Simulator::InstructionDecode (this=0xa33540,
> instr=0xa33d0c) at simulator_mips.cc:1737
> #17 0x0037f2c6 in dart::Simulator::Execute (this=0xa33540) at
> simulator_mips.cc:2046
> #18 0x0037f6ba in dart::Simulator::Call (this=0xa33540, entry=14954560,
> parameter0=15170496, parameter1=19231628, parameter2=19231564,
> parameter3=19116544, fp_return=false, fp_args=false) at simulator_mips.cc:2147
> #19 0x001392e9 in dart::IsolateRunStateManager::~IsolateRunStateManager () at
> /Users/johnmccutchan/workspace/dart-repo/dart/runtime/vm/isolate.h:67
> #20 0x001392e9 in dart::DartEntry::InvokeFunction (function=@0x1257364,
> arguments=@0x125734c, arguments_descriptor=@0x125738c, context=@0x123b200) at
> dart_entry.cc:67
> #21 0x00139588 in dart::DartEntry::InvokeFunction (function=@0x1257364,
> arguments=@0x125734c, arguments_descriptor=@0x125738c) at dart_entry.cc:36
> #22 0x00139680 in dart::DartEntry::InvokeFunction (function=@0x1257364,
> arguments=@0x125734c) at dart_entry.cc:26
> #23 0x00018613 in Dart_Invoke (target=0x1256e3c, name=0x1256e40,
> number_of_arguments=0, arguments=0x0) at dart_api_impl.cc:2974
> #24 0x00003dcf in dart::bin::main (argc=5, argv=0xbffff9cc) at main.cc:864
> #25 0x000022a5 in start ()

This crash is happening because there is a branch offset that is too large for a
MIPS branch instruction. I am working on fixing this, now. You could either
split the big functions into smaller functions, or mark the test as crashing on
MIPS.

[Cutch, 2013-07-25 00:09:32]

On 2013/07/25 00:08:06, zra wrote:
> This crash is happening because there is a branch offset that is too large for
a
> MIPS branch instruction. I am working on fixing this, now. You could either
> split the big functions into smaller functions, or mark the test as crashing
on
> MIPS.

I figured as much and the CL marks just the shuffle test as crashing. The rest
of the tests run under simmips now.

[regis, 2013-07-25 16:47:56]

LGTM

[srdjan, 2013-07-25 17:02:14]

Do you have tests that trigger these optimizations?

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:39: DEFINE_FLAG(bool, disable_simd_inline,
false,
Think positive, rename flag enable_simd_inline, default true..

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:50: return !FLAG_disable_simd_inline;
Why don't you use the ifdef on flag definition?

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2268: return false;
Bad indentation.

[Cutch, 2013-07-25 17:08:13]

All of the float32x4 tests trigger the inline optimizations.

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:50: return !FLAG_disable_simd_inline;
On 2013/07/25 17:02:14, srdjan wrote:
> Why don't you use the ifdef on flag definition?

Because enabling it on MIPS will cause a crash.

https://codereview.chromium.org/20125005/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2268: return false;
On 2013/07/25 17:02:14, srdjan wrote:
> Bad indentation.

Done.

[Cutch, 2013-07-25 17:31:26]

Committed patchset #3 manually as r25481 (presubmit successful).

[srdjan, 2013-07-25 17:36:52]

lgtm