Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012073002: Reduce the number of dynamic calls. (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
Reviewers:
skybrian
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-protobuf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 1 comment Download
M lib/src/protobuf/generated_message.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M lib/src/protobuf/utils.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
4 years, 7 months ago (2016-05-25 20:47:12 UTC) #2
skybrian
LGTM https://codereview.chromium.org/2012073002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2012073002/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Bugfix: eliminate some dynamic calls to improve ...
4 years, 7 months ago (2016-05-25 20:52:55 UTC) #3
Jacob
On 2016/05/25 20:52:55, skybrian wrote: > LGTM > > https://codereview.chromium.org/2012073002/diff/1/CHANGELOG.md > File CHANGELOG.md (right): > ...
4 years, 7 months ago (2016-05-25 20:54:26 UTC) #4
Jacob
4 years, 7 months ago (2016-05-25 21:11:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
76cb907d9e394a7885cee867948f33e3a726b34b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698