Make LibraryMirror.members an internal native and lazy.

Make LibraryMirror.members an internal native and lazy.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25451

[rmacnak, 2013-07-24 20:29:04]

Improves currentMirrorSystem() from ~140 to ~30 ms.

[siva, 2013-07-24 22:41:34]

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1171: Function& func = Function::Handle();
You don't need these 3 handles, see comment below.

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1182: klass ^= entry.raw();
you could replace this with the Cast operator:

   const Klass& klass = Klass::Cast(entry);

(this doesn't create a new handle just casts the existing handle to
the new type which you have already checked and verified by doing a
entry.IsClass() above).

Ditto comment for 'field' and 'func' below.

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1196: }
Replace this with the internal class id check as discussed offline.

[rmacnak, 2013-07-24 22:51:43]

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1182: klass ^= entry.raw();
On 2013/07/24 22:41:35, siva wrote:
> you could replace this with the Cast operator:
> 
>    const Klass& klass = Klass::Cast(entry);
> 
> (this doesn't create a new handle just casts the existing handle to
> the new type which you have already checked and verified by doing a
> entry.IsClass() above).
> 
> Ditto comment for 'field' and 'func' below.

Done.

https://codereview.chromium.org/20119002/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1196: }
On 2013/07/24 22:41:35, siva wrote:
> Replace this with the internal class id check as discussed offline.

Done.

[siva, 2013-07-24 22:59:45]

lgtm

[rmacnak, 2013-07-24 23:51:19]

Committed patchset #3 manually as r25451 (presubmit successful).

[ahe, 2013-07-25 08:27:19]

DBC

https://codereview.chromium.org/20119002/diff/12001/runtime/lib/mirrors_impl....
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/20119002/diff/12001/runtime/lib/mirrors_impl....
runtime/lib/mirrors_impl.dart:828: return _members;
You need to return something that is immutable.

_makeMemberMap creates a mutable map.

But don't sweat it, we're planning to use lists instead of maps.  It is easier
to create an immutable list.

[rmacnak, 2013-07-25 16:31:09]

https://codereview.chromium.org/20119002/diff/12001/runtime/lib/mirrors_impl....
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/20119002/diff/12001/runtime/lib/mirrors_impl....
runtime/lib/mirrors_impl.dart:828: return _members;
On 2013/07/25 08:27:19, ahe wrote:
> You need to return something that is immutable.
> 
> _makeMemberMap creates a mutable map.
> 
> But don't sweat it, we're planning to use lists instead of maps.  It is easier
> to create an immutable list.

Yeah, we're holding the status quo here.