Added a way to let the outer event loop run periodically so that things like

Added a way to let the outer event loop run periodically so that things like
DOM updates don't get completely starved when doing lots of sync tests.
See issue https://code.google.com/p/dart/issues/detail?id=11450

Also, TestCase._run now always returns a Future, so _nextBatch is a misnomer;
renamed it to _nextTest and removed the loop.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25480

[Siggi Cherem (dart-lang), 2013-07-24 23:34:06]

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:762: if ((now - _lastBreath) >= BREATH_INTERVAL)
{
consider moving this test up to _nextTestCase? then the question is just whether
to do runAsync or Timer.run there?

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:764: new Future(_nextTestCase);
isn't this the same as runAsync(_nextTestCase).

If we want to explicitly let the DOM run, we'd need to do
Timer.run(_nextTextCase)

[gram, 2013-07-24 23:54:52]

PTAL

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:762: if ((now - _lastBreath) >= BREATH_INTERVAL)
{
On 2013/07/24 23:34:06, Siggi Cherem (dart-lang) wrote:
> consider moving this test up to _nextTestCase? then the question is just
whether
> to do runAsync or Timer.run there?

_nextTestCase first increments the counter so there is a difference. I have
renamed this to _runTest which is a bit more accurate and makes the distinction
with _nextTestCase a bit clearer.

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:764: new Future(_nextTestCase);
On 2013/07/24 23:34:06, Siggi Cherem (dart-lang) wrote:
> isn't this the same as runAsync(_nextTestCase).
> 
> If we want to explicitly let the DOM run, we'd need to do
> Timer.run(_nextTextCase)

Done.

[Siggi Cherem (dart-lang), 2013-07-25 00:13:09]

other than the comment below, lgtm

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:762: if ((now - _lastBreath) >= BREATH_INTERVAL)
{
On 2013/07/24 23:54:52, gram wrote:
> On 2013/07/24 23:34:06, Siggi Cherem (dart-lang) wrote:
> > consider moving this test up to _nextTestCase? then the question is just
> whether
> > to do runAsync or Timer.run there?
> 
> _nextTestCase first increments the counter so there is a difference. I have
> renamed this to _runTest which is a bit more accurate and makes the
distinction
> with _nextTestCase a bit clearer.
> 

basically it seems strange that we do runAsync on one case and Timer.run +
runAsync in the other.

Maybe remove runAsync from nextTestcase, but put it below in the else branch?

[gram, 2013-07-25 00:33:22]

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/20115007/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:762: if ((now - _lastBreath) >= BREATH_INTERVAL)
{
On 2013/07/25 00:13:09, Siggi Cherem (dart-lang) wrote:
> On 2013/07/24 23:54:52, gram wrote:
> > On 2013/07/24 23:34:06, Siggi Cherem (dart-lang) wrote:
> > > consider moving this test up to _nextTestCase? then the question is just
> > whether
> > > to do runAsync or Timer.run there?
> > 
> > _nextTestCase first increments the counter so there is a difference. I have
> > renamed this to _runTest which is a bit more accurate and makes the
> distinction
> > with _nextTestCase a bit clearer.
> > 
> 
> basically it seems strange that we do runAsync on one case and Timer.run +
> runAsync in the other.
> 
> Maybe remove runAsync from nextTestcase, but put it below in the else branch?

Done.

[Siggi Cherem (dart-lang), 2013-07-25 00:50:42]

lgtm

https://codereview.chromium.org/20115007/diff/11001/pkg/unittest/lib/unittest...
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/20115007/diff/11001/pkg/unittest/lib/unittest...
pkg/unittest/lib/unittest.dart:702: _runTest();
I think this one needs to still call runAsync?

[gram, 2013-07-25 17:17:31]

Committed patchset #3 manually as r25480 (presubmit successful).