Issue 201013002: x64 code improvements and cleanups.

Issue 201013002: x64 code improvements and cleanups. (Closed)

Created:
6 years, 9 months ago by srdjan

Modified:
6 years, 9 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

x64 code improvements and cleanups. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=33766

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
M	runtime/vm/assembler_x64.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/201013002/diff/40001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/201013002/diff/40001/runtime/vm/assembler_x64.cc#newcode2560 runtime/vm/assembler_x64.cc:2560: cmpq(reg, Address::AddressBaseImm32(pp, offset - kHeapObjectTag)); AddressBaseImm32 emits a ...

6 years, 9 months ago (2014-03-17 19:29:58 UTC) #2

srdjan

https://codereview.chromium.org/201013002/diff/40001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/201013002/diff/40001/runtime/vm/assembler_x64.cc#newcode2560 runtime/vm/assembler_x64.cc:2560: cmpq(reg, Address::AddressBaseImm32(pp, offset - kHeapObjectTag)); On 2014/03/17 19:29:58, zra ...

6 years, 9 months ago (2014-03-17 19:54:32 UTC) #3

srdjan

6 years, 9 months ago (2014-03-17 19:55:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r33766 (presubmit successful).

Expand Messages | Collapse Messages