Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 20101008: Modify the instance test to work with dart2js by using looser matching, (Closed)

Created:
7 years, 5 months ago by gram
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Modify the instance test to work with dart2js by using looser matching, and re-enable the test. See https://code.google.com/p/dart/issues/detail?id=11191 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/unittest/test/instance_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 5 months ago (2013-07-24 23:46:01 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 5 months ago (2013-07-24 23:48:58 UTC) #2
gram
7 years, 5 months ago (2013-07-24 23:53:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25452 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698