Issue 200983002: Re-run a transform when a secondary input starts existing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200983002: Re-run a transform when a secondary input starts existing. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-run a transform when a secondary input starts existing. R=rnystrom@google.com BUG=17480 Committed: https://code.google.com/p/dart/source/detail?r=33729

Patch Set 2 : code review #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -63 lines)			Patch
M	pkg/barback/CHANGELOG.md	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/asset_cascade.dart	View	1	4 chunks	+23 lines, -12 lines	0 comments	Download
M	pkg/barback/lib/src/group_runner.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/phase.dart	View		4 chunks	+9 lines, -31 lines	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View		6 chunks	+18 lines, -4 lines	0 comments	Download
M	pkg/barback/test/package_graph/errors_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	pkg/barback/test/package_graph/transform/transform_test.dart	View		1 chunk	+13 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Couple of things then LGTM. Very nice. https://codereview.chromium.org/200983002/diff/1/pkg/barback/lib/src/asset_cascade.dart File pkg/barback/lib/src/asset_cascade.dart (right): https://codereview.chromium.org/200983002/diff/1/pkg/barback/lib/src/asset_cascade.dart#newcode182 pkg/barback/lib/src/asset_cascade.dart:182: // the ...

6 years, 9 months ago (2014-03-15 01:03:55 UTC) #2

nweiz

6 years, 9 months ago (2014-03-15 02:40:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33729 (presubmit successful).

Expand Messages | Collapse Messages

Issue 200983002: Re-run a transform when a secondary input starts existing. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Messages