Issue 20088002: Make web_socket_ping_test pass on simulators, where it takes > 100ms to send data between sockets(!…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20088002: Make web_socket_ping_test pass on simulators, where it takes > 100ms to send data between sockets(!… (Closed)

Created:
7 years, 5 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make web_socket_ping_test pass on simulators, where it takes > 100ms to send data between sockets(!). BUG= Committed: https://code.google.com/p/dart/source/detail?r=25416

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tests/standalone/io/web_socket_ping_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Anders Johnsen

Committed patchset #1 manually as r25416 (presubmit successful).

7 years, 5 months ago (2013-07-24 14:27:32 UTC) #3

Søren Gjesse

7 years, 5 months ago (2013-07-24 14:47:40 UTC) #4

Message was sent while issue was closed.

lgtm

However we should consider another aproach as we will probably see flakes on
this. Also this now always takes 2 seconds.