Issue 200723009: Avoid canonicalization issues in the pub web socket API tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200723009: Avoid canonicalization issues in the pub web socket API tests. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid canonicalization issues in the pub web socket API tests. We were using [path.absolute], which can return a different string than pub's understanding of the current working directory on OS X bots where /tmp is symlinked to /private/tmp. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34094

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 9 months ago (2014-03-19 01:42:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34094 (presubmit successful).

Expand Messages | Collapse Messages