Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of…

Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of interpolation.

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25435

[Alan Knight, 2013-07-23 23:24:29]

This lets you omit the outermost message send and the first layer of string
interpolation, making it a lot more pleasant to write complex messages. Also a
couple of minor bug fixes that I've commented below.

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
File pkg/intl/lib/extract_messages.dart (right):

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:181: return
super.visitMethodInvocation(node);
I changed the super call here because it just seemed to be wrong. I think
visitNode is a no-op, so it didn't really make a difference previously.

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:192: if (reason != null) {
If suppress warnings was on, this was including the invalid message in the
output.

[Emily Fortuna, 2013-07-24 18:35:51]

looks good. minor stuff.

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
File pkg/intl/lib/extract_messages.dart (right):

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:187: * the [IntlMessage] object from it and
store it in [messages].
can you update the comment  here and explain what it means if it returns true vs
false?

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:246: // TODO(alanknight): Refactor this to
reduce code duplication.
why not refactor now? :-)

[Alan Knight, 2013-07-24 19:50:09]

PTAL

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
File pkg/intl/lib/extract_messages.dart (right):

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:187: * the [IntlMessage] object from it and
store it in [messages].
On 2013/07/24 18:35:51, Emily Fortuna wrote:
> can you update the comment  here and explain what it means if it returns true
vs
> false?

Done. Which also pointed out that I was returning the wrong value below.

https://codereview.chromium.org/20072002/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:246: // TODO(alanknight): Refactor this to
reduce code duplication.
On 2013/07/24 18:35:51, Emily Fortuna wrote:
> why not refactor now? :-)

Because I looked a bit and it didn't look easy. But done now. Function
parameterized by two other functions, but it's all deep in internals and it does
cut down on the duplication.

[Emily Fortuna, 2013-07-24 19:56:06]

thanks! lgtm!

[Alan Knight, 2013-07-24 20:02:06]

Committed patchset #2 manually as r25435 (presubmit successful).