Issue 200693002: Set VMTag from stubs when transitioning between Dart and Native

Issue 200693002: Set VMTag from stubs when transitioning between Dart and Native (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Set VMTag from stubs when transitioning between Dart and Native R=asiva@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=34065

Patch Set 6 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -27 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/exceptions.cc	View	1	4 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/native_entry.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame_arm.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_ia32.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_mips.h	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_x64.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3 4 5	10 chunks	+73 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5	10 chunks	+72 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2 3 4 5	13 chunks	+74 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5	10 chunks	+73 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

siva

https://codereview.chromium.org/200693002/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://codereview.chromium.org/200693002/diff/1/runtime/vm/stub_code_ia32.cc#newcode62 runtime/vm/stub_code_ia32.cc:62: // Mark that the isolate is executing VM code. ...

6 years, 9 months ago (2014-03-14 20:45:39 UTC) #2

Cutch

https://codereview.chromium.org/200693002/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://codereview.chromium.org/200693002/diff/1/runtime/vm/stub_code_ia32.cc#newcode866 runtime/vm/stub_code_ia32.cc:866: __ pushl(ECX); On 2014/03/14 20:45:39, siva wrote: > As ...

6 years, 9 months ago (2014-03-17 15:46:01 UTC) #3

Cutch

This is ready for review. + zra for ARM/MIPS changes. Waiting on Golem results.

6 years, 9 months ago (2014-03-17 21:31:27 UTC) #4

Cutch

Golem runs: http://108.170.219.2:8080/Comparison#targetA%3Ddart%3BmachineTypeA%3Dlinux-ia32%3BrevisionA%3D33778%3BpatchA%3Djohnmccutchan-c6t1%3BtargetB%3Ddart%3BmachineTypeB%3Dlinux-ia32%3BrevisionB%3D33778%3BpatchB%3DNone http://108.170.219.2:8080/Comparison#targetA%3Ddart%3BmachineTypeA%3Dlinux-x64%3BrevisionA%3D33778%3BpatchA%3Djohnmccutchan-c6t1%3BtargetB%3Ddart%3BmachineTypeB%3Dlinux-x64%3BrevisionB%3D33778%3BpatchB%3DNone

6 years, 9 months ago (2014-03-17 22:05:08 UTC) #6

Cutch

6 years, 9 months ago (2014-03-18 21:26:17 UTC) #8

Message was sent while issue was closed.

Committed patchset #6 manually as r34065 (presubmit successful).

Expand Messages | Collapse Messages