Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 200583002: Analyzer snapshot with disabled 'this.field' generation. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Analyzer snapshot with disabled 'this.field' generation. This should help to workaround https://code.google.com/p/dart/issues/detail?id=17483 is Spark. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1123 lines, -951 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 90 chunks +259 lines, -90 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 17 chunks +40 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 24 chunks +59 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 114 chunks +526 lines, -688 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 24 chunks +53 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 14 chunks +34 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 14 chunks +36 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 23 chunks +51 lines, -27 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 9 chunks +16 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 5 chunks +16 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 9 months ago (2014-03-14 18:11:39 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-14 18:18:59 UTC) #2
scheglov
6 years, 9 months ago (2014-03-14 18:22:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698