Allow multiple-entry libraries in code_transformers

Allow multiple-entry libraries in code_transformers

R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33772

[Siggi Cherem (dart-lang), 2014-03-14 21:31:43]

https://codereview.chromium.org/200543006/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/dart_sdk.dart (right):

https://codereview.chromium.org/200543006/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/dart_sdk.dart:53: String get
testingDartSdkDirectory {
i just copied this from your CL, but I don't plan to submit it until you do (I
was just using it locally for my other cls)

[Siggi Cherem (dart-lang), 2014-03-15 00:07:48]

On second thoguht - let's wait on this review

I just synced to the latest version of the analyzer, and we need to change how
we discover assets.

The latest analyzer changed how they resolve libraries. It seems like they are
resolving them as soon as they see the import. So we can't rely on the analzyer
to walk the import directives, we probably need to only do an AST parse,
discover files ourselves, and then update sources for the analyzer context.

[Siggi Cherem (dart-lang), 2014-03-15 01:10:19]

OK - now this is ready for a look.

(Note: this is built on top of the other change that fixes issue 17502)

[blois, 2014-03-17 16:55:45]

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:77: source._libraryElement =
_context.computeLibraryElement(source);
computeLibraryElement is long-running the first time, but does it need to be
cached for later access? It looks like the analyzer does some internal caching
as well.

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:79: return source == null ?
null : source._libraryElement;
If source can be null then it will crash in the if statement.

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:156: _entryLibraries = [];
_entryLibraries = entryPoints.map((id) {
  var source = sources[id];
  source._libraryElement = _context.computeLibraryElement(source);
  return source._libraryElement;
}).toList();

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:166: var all = new Set();
=> _entryLibraries.expand((lib) => lib.visibleLibraries).toSet();

[Siggi Cherem (dart-lang), 2014-03-17 20:13:39]

Thanks

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:77: source._libraryElement =
_context.computeLibraryElement(source);
On 2014/03/17 16:55:45, blois wrote:
> computeLibraryElement is long-running the first time, but does it need to be
> cached for later access? It looks like the analyzer does some internal caching
> as well.

Good to know, I had assumed that it didn't cache it. I removed the extra caching
here then.

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:79: return source == null ?
null : source._libraryElement;
On 2014/03/17 16:55:45, blois wrote:
> If source can be null then it will crash in the if statement.

good catch! this was a last minute refactor and I also stubmbled upon this when
testing it out again this morning.

Fixed.

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:156: _entryLibraries = [];
On 2014/03/17 16:55:45, blois wrote:
> _entryLibraries = entryPoints.map((id) {
>   var source = sources[id];
>   source._libraryElement = _context.computeLibraryElement(source);
>   return source._libraryElement;
> }).toList();

Done.

https://codereview.chromium.org/200543006/diff/50006/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:166: var all = new Set();
On 2014/03/17 16:55:45, blois wrote:
> => _entryLibraries.expand((lib) => lib.visibleLibraries).toSet();

Done.

[blois, 2014-03-17 20:26:18]

lgtm

[Siggi Cherem (dart-lang), 2014-03-17 20:30:19]

Committed patchset #4 manually as r33772 (presubmit successful).