Restore batch mode in the Dart-based Dart analyzer

Restore batch mode in the Dart-based Dart analyzer

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33709

[scheglov, 2014-03-14 18:25:25]

LGTM

[scheglov, 2014-03-14 18:25:33]

LGTM

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
File pkg/analyzer/bin/analyzer.dart (right):

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
pkg/analyzer/bin/analyzer.dart:32: dynamic _runAnalyzer(CommandLineOptions
options, [bool async = true]) {
You could remove the return type, it is dynamic by default.

[Brian Wilkerson, 2014-03-14 18:31:17]

LGTM, once the return type question is resolved.

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
File pkg/analyzer/bin/analyzer.dart (right):

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
pkg/analyzer/bin/analyzer.dart:25: return _runAnalyzer(options, false);
I'm not sure why you added return statements to this method, given that it's
return type is "void".

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
pkg/analyzer/bin/analyzer.dart:32: dynamic _runAnalyzer(CommandLineOptions
options, [bool async = true]) {
Is this method used outside of 'main'? If not, and if the returns can be removed
there, then this can revert to being 'void'.

[jwren, 2014-03-14 19:05:37]

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
File pkg/analyzer/bin/analyzer.dart (right):

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
pkg/analyzer/bin/analyzer.dart:25: return _runAnalyzer(options, false);
On 2014/03/14 18:31:17, Brian Wilkerson wrote:
> I'm not sure why you added return statements to this method, given that it's
> return type is "void".

The return type is required to be ErrorSeverity on line 102.

The mistake here is that the return on line 28 isn't required.  I put it there
because not having the return on 25 was a hard to see issue, but if we handle a
Future from the call on line 28, it won't be a "return" that is missing.

https://codereview.chromium.org/200523003/diff/20001/pkg/analyzer/bin/analyze...
pkg/analyzer/bin/analyzer.dart:32: dynamic _runAnalyzer(CommandLineOptions
options, [bool async = true]) {
This method is being called indirectly below, see line 102.  It is passed as
"handler" on line 23.

[jwren, 2014-03-14 19:09:28]

Committed patchset #3 manually as r33709 (presubmit successful).