Issue 20052002: Small inferrer improvments, and one refactoring in the inferrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20052002: Small inferrer improvments, and one refactoring in the inferrer. (Closed)

Created:
7 years, 5 months ago by ngeoffray

Modified:
7 years, 5 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Small inferrer improvments, and one refactoring in the inferrer. - Make the try/catch handling put a phi at the end of the try block. - Add a [InferrerEngine.addReturnTypeFor] to allow different implementations. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=25406

Patch Set 1 : #

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -87 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/types/container_tracer.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart	View	1	18 chunks	+59 lines, -76 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1	6 chunks	+18 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_try_catch_test.dart	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

7 years, 5 months ago (2013-07-24 11:10:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25406 (presubmit successful).

Expand Messages | Collapse Messages