Issue 200483003: - Do not rely on time to seed the default PRNG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200483003: - Do not rely on time to seed the default PRNG. (Closed)

Created:
6 years, 9 months ago by Ivan Posva

Modified:
6 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Do not rely on time to seed the default PRNG. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33704

Patch Set 2 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
M	runtime/lib/math.cc	View		1 chunk	+8 lines, -0 lines	1 comment	Download
M	runtime/lib/math_patch.dart	View	1	1 chunk	+3 lines, -5 lines	1 comment	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

https://codereview.chromium.org/200483003/diff/20001/runtime/lib/math.cc File runtime/lib/math.cc (right): https://codereview.chromium.org/200483003/diff/20001/runtime/lib/math.cc#newcode185 runtime/lib/math.cc:185: seed |= (static_cast<int64_t>(rnd->NextUInt32())) << 32; I would prefer seed ...

6 years, 9 months ago (2014-03-14 17:27:12 UTC) #2

Ivan Posva

Committed patchset #2 manually as r33704 (presubmit successful).

6 years, 9 months ago (2014-03-14 17:30:40 UTC) #4

siva

6 years, 9 months ago (2014-03-17 17:46:01 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/200483003/diff/20001/runtime/lib/math_patch.dart
File runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/200483003/diff/20001/runtime/lib/math_patch.d...
runtime/lib/math_patch.dart:157: static var _prng = new Random(_initialSeed());
This can potentially result in an overflow error when the flag
--throw_on_javascript_int_overflow flag is used.

Expand Messages | Collapse Messages

Issue 200483003: - Do not rely on time to seed the default PRNG. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages