Issue 200473006: Make barback's onAsset streams broadcast rather than single-subscriber.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200473006: Make barback's onAsset streams broadcast rather than single-subscriber. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make barback's onAsset streams broadcast rather than single-subscriber. This brings these streams in line with the other Barback streams, allows us to remove [Phase._next], and paves the way for re-running transformers when a secondary input is added. R=rnystrom@google.com BUG=17480 Committed: https://code.google.com/p/dart/source/detail?r=33727

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -39 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/group_runner.dart	View	4 chunks	+10 lines, -9 lines	0 comments	Download
M	pkg/barback/lib/src/phase.dart	View	6 chunks	+13 lines, -25 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/phase_output.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 9 months ago (2014-03-14 23:15:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33727 (presubmit successful).

Expand Messages | Collapse Messages