Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 200423006: Fix batch mode to now print out errors, this gets us closer to the FYI bot passing (Closed)

Created:
6 years, 9 months ago by jwren
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix batch mode to now print out errors, this gets us closer to the FYI bot passing R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=33725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -29 lines) Patch
M pkg/analyzer/bin/analyzer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 2 chunks +43 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jwren
6 years, 9 months ago (2014-03-14 22:13:22 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-14 22:15:15 UTC) #2
jwren
6 years, 9 months ago (2014-03-14 22:20:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698