Load the transformer isolate code from pub's asset directory.

Load the transformer isolate code from pub's asset directory.

This renames "resources" to "asset" in the SDK, to better match the suggested
package layout guidelines.

BUG=17506
R=dgrove@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33786

[nweiz, 2014-03-15 02:22:33]

Including dgrove for create_sdk changes.

[Bob Nystrom, 2014-03-17 21:16:07]

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/as...
File sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart (right):

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart:5: // Explicitly avoid
using a library tag because pub will add additional imports
Wording this as an imperative sentence seems a bit strange. How about:

// Note: This explicitly avoids...

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart:17: import
'<<URL_BASE>>/packages/barback/src/internal_asset.dart';
How does the analyzer handle these?

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right):

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:39:
.replaceAll('<<URL_BASE>>', baseUrl);
This can be indented +4 to line up with readResource().

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/io.dart:400: /// Resolves [target] relative to the
path to pub's `resource` directory.
Update doc. Also, might as well rename this assetPath, right?

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/io.dart:412: String readResource(String target) =>
readTextFile(resourcePath(target));
Ditto.

[nweiz, 2014-03-17 22:20:40]

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/as...
File sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart (right):

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart:5: // Explicitly avoid
using a library tag because pub will add additional imports
On 2014/03/17 21:16:07, Bob Nystrom wrote:
> Wording this as an imperative sentence seems a bit strange. How about:
> 
> // Note: This explicitly avoids...

Done.

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart:17: import
'<<URL_BASE>>/packages/barback/src/internal_asset.dart';
On 2014/03/17 21:16:07, Bob Nystrom wrote:
> How does the analyzer handle these?

Poorly. That's why this CL adds a skip to the analyzer status file. Followup CLs
will make this work.

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right):

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:39:
.replaceAll('<<URL_BASE>>', baseUrl);
On 2014/03/17 21:16:07, Bob Nystrom wrote:
> This can be indented +4 to line up with readResource().

Done.

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/io.dart:400: /// Resolves [target] relative to the
path to pub's `resource` directory.
On 2014/03/17 21:16:07, Bob Nystrom wrote:
> Update doc. Also, might as well rename this assetPath, right?

Done.

https://codereview.chromium.org/200323008/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/io.dart:412: String readResource(String target) =>
readTextFile(resourcePath(target));
On 2014/03/17 21:16:07, Bob Nystrom wrote:
> Ditto.

Done.

[dgrove, 2014-03-17 22:31:43]

lgtm

[Bob Nystrom, 2014-03-17 23:03:15]

LGTM!

[nweiz, 2014-03-17 23:20:21]

Committed patchset #3 manually as r33786 (presubmit successful).