Issue 200233002: Add exitCode getter counterpart to the existing setter in dart:io.

Issue 200233002: Add exitCode getter counterpart to the existing setter in dart:io. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add exitCode getter counterpart to the existing setter in dart:io. BUG=https://code.google.com/p/dart/issues/detail?id=16217 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33737

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
M	runtime/bin/io_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/process.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/process_patch.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/io/process.dart	View	1 2	2 chunks	+17 lines, -2 lines	0 comments	Download
M	tests/standalone/io/process_set_exit_code_script.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/200233002/diff/20001/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/200233002/diff/20001/sdk/lib/io/process.dart#newcode57 sdk/lib/io/process.dart:57: * on normal termination. Maybe mention that the ...

6 years, 9 months ago (2014-03-14 12:04:49 UTC) #2

Anders Johnsen

https://codereview.chromium.org/200233002/diff/20001/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/200233002/diff/20001/sdk/lib/io/process.dart#newcode57 sdk/lib/io/process.dart:57: * on normal termination. On 2014/03/14 12:04:49, Søren Gjesse ...

6 years, 9 months ago (2014-03-17 10:40:05 UTC) #3

Anders Johnsen

6 years, 9 months ago (2014-03-17 10:40:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r33737 (presubmit successful).

Expand Messages | Collapse Messages