Add ContentShell tests to dartium android builder.

Add ContentShell tests to dartium android builder.

BUG=

Closing issue because we will commit a much cleaner version, supporting multiple phones and not including a shell script.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36739

[ricow1, 2014-03-14 13:17:17]

https://codereview.chromium.org/200193004/diff/1/tools/bots/run_android_tests.sh
File tools/bots/run_android_tests.sh (right):

https://codereview.chromium.org/200193004/diff/1/tools/bots/run_android_tests...
tools/bots/run_android_tests.sh:11: set -v
I thought you where doing a shell script because you needed to start stuff in
the background, there is really nothing in here you can't do from python?

[kustermann, 2014-03-14 13:34:09]

I'll let rico decide when this is good engouh.

There are a lot of assumptions, but I'd be ok with it (for the short term).

https://codereview.chromium.org/200193004/diff/1/tools/bots/dartium_android.py
File tools/bots/dartium_android.py (right):

https://codereview.chromium.org/200193004/diff/1/tools/bots/dartium_android.p...
tools/bots/dartium_android.py:79: subprocess.call([os.path.join(SCRIPT_DIR,
'run_android_tests.sh'),
I'd strongly encourage you to change this to call_checked.

https://codereview.chromium.org/200193004/diff/1/tools/bots/run_android_tests.sh
File tools/bots/run_android_tests.sh (right):

https://codereview.chromium.org/200193004/diff/1/tools/bots/run_android_tests...
tools/bots/run_android_tests.sh:22: 8083 8083 8084 8084 &
Are we leaking these adb_reverse_forwarder.py processes ?

Could you record the PID and kill it after running test.py.

[Bill Hesse, 2014-03-14 14:14:58]

Made the changes suggested by Martin.

[ricow1, 2014-03-14 14:18:09]

since we all agree this is a temporary location of these, LGTM

[Bill Hesse, 2014-05-12 11:31:24]

On 2014/03/14 14:18:09, ricow1 wrote:
> since we all agree this is a temporary location of these, LGTM

Closing issue because we will commit a much cleaner version, supporting multiple
phones and not including a shell script.

[Bill Hesse, 2014-05-28 14:05:52]

We need this committed, because this is now on Dart.FYI and will move to the
main buildbot, and content_shell is going into editor.  It is working well.

https://codereview.chromium.org/200193004/diff/40001/tools/bots/dartium_andro...
File tools/bots/dartium_android.py (right):

https://codereview.chromium.org/200193004/diff/40001/tools/bots/dartium_andro...
tools/bots/dartium_android.py:79:
subprocess.call_checked([os.path.join(SCRIPT_DIR, 'run_android_tests.sh'),
check_call, not call_checked

done

[Bill Hesse, 2014-05-28 14:06:16]

Committed patchset #5 manually as r36739 (presubmit successful).