Issue 200193002: Alternative fix for .call invocation of closures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200193002: Alternative fix for .call invocation of closures. (Closed)

Created:
6 years, 9 months ago by Florian Schneider

Modified:
6 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, rmacnak

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Alternative fix for .call invocation of closures. This also covers "closurization" of the .call method. This relies on the fact that f.call === f if f is a closure. This means that adding a simple getter to _FunctionImpl that returns this is enough. No need for a separate dispatch. This CL reverts the previous fix for issue 12602 (modulo the additional tests). BUG=dartbug.com/17473, dartbug.com/12602 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33736

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -88 lines)			Patch
M	runtime/lib/function.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+5 lines, -12 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View	6 chunks	+4 lines, -15 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+0 lines, -51 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM I guess this change is not in the way of getting rid of the ...

6 years, 9 months ago (2014-03-14 16:52:55 UTC) #2

Florian Schneider

6 years, 9 months ago (2014-03-17 10:31:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33736 (presubmit successful).

Expand Messages | Collapse Messages