Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 200083002: Use mutex around getaddrinfo on windows, as it's not thread-safe. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use mutex around getaddrinfo on windows, as it's not thread-safe. BUG=https://code.google.com/p/dart/issues/detail?id=17237 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M runtime/bin/socket_win.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-14 09:42:21 UTC) #1
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-14 10:14:54 UTC) #2
Anders Johnsen
6 years, 9 months ago (2014-03-14 10:25:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698