Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 20006003: Fix a regression in ObjectMirror.setFieldAsync. (Closed)

Created:
7 years, 5 months ago by rmacnak
Modified:
7 years, 5 months ago
Reviewers:
ahe, siva
CC:
reviews_dartlang.org, ahe, Michael Lippautz (Google)
Visibility:
Public.

Description

Fix a regression in ObjectMirror.setFieldAsync (issue 11898). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
Separating regression fix from new tests.
7 years, 5 months ago (2013-07-22 23:19:19 UTC) #1
siva
lgtm
7 years, 5 months ago (2013-07-22 23:33:45 UTC) #2
rmacnak
Committed patchset #1 manually as r25323 (presubmit successful).
7 years, 5 months ago (2013-07-23 00:02:32 UTC) #3
ahe
7 years, 5 months ago (2013-07-24 09:46:31 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698