Issue 19997003: Implement more restrictive checking of typedefs illegally referring to

Issue 19997003: Implement more restrictive checking of typedefs illegally referring to (Closed)

Created:
7 years, 5 months ago by regis

Modified:
7 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement more restrictive checking of typedefs illegally referring to themselves and fix vm issue 9611. Update a test and add a test. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25382

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -18 lines)			Patch
M	runtime/vm/class_finalizer.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	2 chunks	+34 lines, -16 lines	0 comments	Download
M	tests/language/function_type_alias6_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	tests/language/function_type_alias9_test.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/19997003/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/19997003/diff/1/runtime/vm/class_finalizer.cc#newcode1670 runtime/vm/class_finalizer.cc:1670: GrowableArray<intptr_t>* visited) { ASSERT(visited != NULL).

7 years, 5 months ago (2013-07-23 22:56:33 UTC) #2

regis

Thanks https://codereview.chromium.org/19997003/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/19997003/diff/1/runtime/vm/class_finalizer.cc#newcode1670 runtime/vm/class_finalizer.cc:1670: GrowableArray<intptr_t>* visited) { On 2013/07/23 22:56:34, srdjan wrote: ...

7 years, 5 months ago (2013-07-23 23:14:35 UTC) #3

regis

7 years, 5 months ago (2013-07-23 23:17:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25382 (presubmit successful).

Expand Messages | Collapse Messages