Issue 19996008: automatically clean up CompoundBinding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19996008: automatically clean up CompoundBinding (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly

Modified:
7 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

automatically clean up CompoundBinding rough port of https://github.com/Polymer/mdv/commit/907455b2196f06650c5cdfbdb145e6eda2861750 We already handle most of the cleanup automatically; CompoundBinding was the main outlier. I'm not completely sold on "close" being public, but it's needed if "bind" is going to start the subscription immediately (like it does now). R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25438

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
	M	pkg/mdv/lib/src/template_iterator.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/observe/lib/src/compound_binding.dart	View	1 2	5 chunks	+18 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

Jennifer Messerly

7 years, 5 months ago (2013-07-24 20:54:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r25438 (presubmit successful).