Issue 199873004: Prevent hoisting of certain check nodes, including [HTypeKnow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199873004: Prevent hoisting of certain check nodes, including [HTypeKnow (Closed)

Created:
6 years, 9 months ago by sra1

Modified:
6 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, herhut

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Prevent hoisting of certain check nodes, including [HTypeKnow This CL is cloned from https://chromiumcodereview.appspot.com/206553002/ Committed: https://code.google.com/p/dart/source/detail?r=34213

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -18 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		4 chunks	+19 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1	5 chunks	+21 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	tests/compiler/dart2js_extra/17645_test.dart	View		1 chunk	+74 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sra1

Committed patchset #2 manually as r34213 (presubmit successful).

6 years, 9 months ago (2014-03-20 22:17:08 UTC) #1

floitsch

6 years, 9 months ago (2014-03-21 14:28:18 UTC) #2

Message was sent while issue was closed.

LGTM.

We still need to add a test for the throwing instructions.