Issue 199793010: pkg/matcher: test cleanup

Issue 199793010: pkg/matcher: test cleanup (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/matcher: test cleanup R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34342

Patch Set 2 : fixed skipped test #

Total comments: 8

Patch Set 3 : nits #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -202 lines)			Patch
M	pkg/matcher/test/matchers_minified_test.dart	View		9 chunks	+27 lines, -25 lines	0 comments	Download
M	pkg/matcher/test/matchers_test.dart	View	1	53 chunks	+90 lines, -96 lines	0 comments	Download
M	pkg/matcher/test/matchers_unminified_test.dart	View		11 chunks	+16 lines, -14 lines	0 comments	Download
M	pkg/matcher/test/mirror_matchers_test.dart	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/matcher/test/pretty_print_minified_test.dart	View		2 chunks	+10 lines, -9 lines	0 comments	Download
M	pkg/matcher/test/pretty_print_test.dart	View		10 chunks	+29 lines, -28 lines	0 comments	Download
M	pkg/matcher/test/pretty_print_unminified_test.dart	View	1 2	2 chunks	+10 lines, -8 lines	0 comments	Download
M	pkg/matcher/test/test_common.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/matcher/test/test_utils.dart	View		3 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

some nits, but lgtm https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/matchers_minified_test.dart File pkg/matcher/test/matchers_minified_test.dart (right): https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/matchers_minified_test.dart#newcode18 pkg/matcher/test/matchers_minified_test.dart:18: const _MINIFIED_NAME = r"[A-Za-z0-9]{1,3}"; FYI- ...

6 years, 9 months ago (2014-03-24 22:55:21 UTC) #2

kevmoo

Committed patchset #3 manually as r34342 (presubmit successful).

6 years, 9 months ago (2014-03-25 00:12:41 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-25 00:12:45 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/matcher...
File pkg/matcher/test/matchers_minified_test.dart (right):

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/matcher...
pkg/matcher/test/matchers_minified_test.dart:18: const _MINIFIED_NAME =
r"[A-Za-z0-9]{1,3}";
On 2014/03/24 22:55:21, blois wrote:
> FYI- style updated- consts no longer need to be caps.

But they SHOULD be. :-)

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/matcher...
File pkg/matcher/test/matchers_test.dart (right):

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/matcher...
pkg/matcher/test/matchers_test.dart:794: class _Bicycle {
On 2014/03/24 22:55:21, blois wrote:
> Not really critical to make classes in tests private- cannot be referenced
> outside of the test folder.

Force of habit. :-)

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/mirror_...
File pkg/matcher/test/mirror_matchers_test.dart (right):

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/mirror_...
pkg/matcher/test/mirror_matchers_test.dart:5: library matcher.mirror;
On 2014/03/24 22:55:21, blois wrote:
> mirror_test?

Done.

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/pretty_...
File pkg/matcher/test/pretty_print_unminified_test.dart (right):

https://codereview.chromium.org/199793010/diff/20001/pkg/matcher/test/pretty_...
pkg/matcher/test/pretty_print_unminified_test.dart:10: library
matcher.pritn_unminified;
On 2014/03/24 22:55:21, blois wrote:
> typo- print.
> 
> and append _test?

Done.

Expand Messages | Collapse Messages