Issue 199723002: Improve the documentation for [TransformLogger.error].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199723002: Improve the documentation for [TransformLogger.error]. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Improve the documentation for [TransformLogger.error]. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33716

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	pkg/barback/lib/src/transform_logger.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Bob Nystrom

LGTM. However, I think I'd like to move towards preferring present tense instead of future ...

6 years, 9 months ago (2014-03-14 17:10:40 UTC) #2

nweiz

On 2014/03/14 17:10:40, Bob Nystrom wrote: > LGTM. > > However, I think I'd like ...

6 years, 9 months ago (2014-03-14 20:23:44 UTC) #3

nweiz

6 years, 9 months ago (2014-03-14 20:24:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33716 (presubmit successful).