Issue 19965003: Fix sublist check, add missing methods and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19965003: Fix sublist check, add missing methods and add tests. (Closed)

Created:
7 years, 5 months ago by floitsch

Modified:
7 years, 5 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix sublist check, add missing methods and add tests for typed data lists. Somehow these lists were still missing functions (in the VM) and the sublist check was broken (in dart2js). R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25333

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+199 lines, -3 lines)			Patch
M	runtime/lib/typed_data.dart	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download
A	tests/lib/typed_data/typed_data_list_test.dart	View	1 chunk	+184 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

7 years, 5 months ago (2013-07-23 09:20:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25333 (presubmit successful).