Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199633007: Switch to using pub build instead of custom build_.dart script (Closed)

Created:
6 years, 9 months ago by Cutch
Modified:
6 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1, turnidge
Visibility:
Public.

Description

Switch to using pub build instead of custom build_.dart script R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=34263

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9445 lines, -106 lines) Patch
M runtime/bin/resources_sources.gypi View 1 1 chunk +64 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/.gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/HACKING.txt View 1 2 chunks +13 lines, -6 lines 0 comments Download
D runtime/bin/vmservice/client/build_.dart View 1 1 chunk +0 lines, -43 lines 0 comments Download
A runtime/bin/vmservice/client/deploy.sh View 1 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/.gitignore View 1 1 chunk +4 lines, -5 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/index.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/browser/dart.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/browser/interop.js View 1 1 chunk +5 lines, -11 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/custom_element/custom-elements.debug.js View 1 1 chunk +984 lines, -0 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/custom_element/custom-elements.min.js View 1 1 chunk +28 lines, -0 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/html_import/html_import.debug.js View 1 1 chunk +36 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/html_import/html_import.min.js View 1 1 chunk +28 lines, -0 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/html_import/src/HTMLImports.js View 1 1 chunk +423 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/html_import/src/Parser.js View 1 1 chunk +107 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/html_import/src/boot.js View 1 1 chunk +37 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/html_import/tools/loader/loader.js View 1 1 chunk +101 lines, -0 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/mutation_observer/mutation_observer.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/mutation_observer/mutation_observer.min.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/elements.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/breakpoint_list.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/collapsible_content.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/curly_block.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/eval_box.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_map.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_profile.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/img/isolate_icon.png View 1 Binary file 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_profile.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/observatory_application.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/observatory_element.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/response_viewer.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/sliding_checkbox.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_frame.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_trace.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_ref.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/boot.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/shadow_dom/shadow_dom.debug.js View 1 1 chunk +7551 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/shadow_dom/shadow_dom.min.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/shadow_dom/src/platform/patches-shadowdom-polyfill.js View 1 3 chunks +29 lines, -17 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/shadow_dom/src/platform/patches-shadowdom-polyfill-before.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/shadow_dom/src/platform/platform-init.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
D runtime/bin/vmservice/client/precommit.sh View 1 1 chunk +0 lines, -54 lines 0 comments Download
M runtime/bin/vmservice/client/pubspec.yaml View 1 1 chunk +6 lines, -1 line 0 comments Download
A runtime/bin/vmservice/client/resources.sh View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
PTAL
6 years, 9 months ago (2014-03-21 18:11:17 UTC) #1
turnidge
lgtm w/ 1 comment. https://codereview.chromium.org/199633007/diff/1/runtime/bin/vmservice/client/HACKING.txt File runtime/bin/vmservice/client/HACKING.txt (right): https://codereview.chromium.org/199633007/diff/1/runtime/bin/vmservice/client/HACKING.txt#newcode23 runtime/bin/vmservice/client/HACKING.txt:23: 6. Run ./deploy.sh Needs something ...
6 years, 9 months ago (2014-03-21 18:16:14 UTC) #2
Cutch
6 years, 9 months ago (2014-03-21 18:24:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r34263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698