Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 199543002: Addtional tests in options.dart to cover 'log' case, and other missed flag tests as they were added. (Closed)

Created:
6 years, 9 months ago by jwren
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

Addtional tests in options.dart to cover 'log' case, and other missed flag tests as they were added. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=33668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M pkg/analyzer/test/error_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/options_test.dart View 3 chunks +43 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jwren
6 years, 9 months ago (2014-03-13 21:07:42 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-13 21:11:53 UTC) #2
jwren
6 years, 9 months ago (2014-03-13 21:51:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33668 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698