Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1994743003: Add top-level collection-manipulation functions. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/collection@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add top-level collection-manipulation functions. These come from various package-specific utility library across the Dart ecosystem. R=lrn@google.com Committed: https://github.com/dart-lang/collection/commit/479be60075f30988870ec66d362ba56e22162b9e

Patch Set 1 #

Total comments: 34

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +17 lines, -0 lines 0 comments Download
M lib/collection.dart View 1 chunk +1 line, -0 lines 0 comments Download
A lib/src/functions.dart View 1 1 chunk +139 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/functions_test.dart View 1 chunk +184 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
nweiz
4 years, 7 months ago (2016-05-19 18:02:40 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart File lib/src/functions.dart (right): https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart#newcode11 lib/src/functions.dart:11: /// The return values of [keyFn] are used ...
4 years, 7 months ago (2016-05-20 12:22:39 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart File lib/src/functions.dart (right): https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart#newcode121 lib/src/functions.dart:121: result[vertex1].contains(vertex3)) { On the other hand, then you have ...
4 years, 7 months ago (2016-05-20 14:50:27 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart File lib/src/functions.dart (right): https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart#newcode27 lib/src/functions.dart:27: /// not passed, [map2]'s value wins. If there are ...
4 years, 7 months ago (2016-05-23 06:44:31 UTC) #4
nweiz
Code review changes
4 years, 7 months ago (2016-05-25 21:29:31 UTC) #5
nweiz
https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart File lib/src/functions.dart (right): https://codereview.chromium.org/1994743003/diff/1/lib/src/functions.dart#newcode11 lib/src/functions.dart:11: /// The return values of [keyFn] are used as ...
4 years, 7 months ago (2016-05-25 21:29:56 UTC) #6
nweiz
4 years, 7 months ago (2016-05-25 21:31:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
479be60075f30988870ec66d362ba56e22162b9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698