Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 199443003: Asset load failures in Barback should produce AssetNotFoundExceptions. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Asset load failures in Barback should produce AssetNotFoundExceptions. Previously they were producing MissingInputExceptions, which is the class used to communicate to listener's on Barback's error stream that a transformer failed due to a missing input. The Transformer documentation said that it should get AssetNotFoundExceptions and those are easier to serialize anyway. R=rnystrom@google.com BUG=17225 Committed: https://code.google.com/p/dart/source/detail?r=33673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -23 lines) Patch
M pkg/barback/lib/src/base_transform.dart View 3 chunks +12 lines, -9 lines 0 comments Download
M pkg/barback/lib/src/transform_node.dart View 4 chunks +12 lines, -13 lines 0 comments Download
M pkg/barback/test/package_graph/errors_test.dart View 1 chunk +11 lines, -1 line 0 comments Download
A pkg/barback/test/transformer/catch_asset_not_found.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M pkg/barback/test/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 9 months ago (2014-03-13 20:53:24 UTC) #1
Bob Nystrom
lgtm
6 years, 9 months ago (2014-03-13 22:03:53 UTC) #2
Bob Nystrom
On 2014/03/13 22:03:53, Bob Nystrom wrote: > lgtm Don't forget to update the pubspec if ...
6 years, 9 months ago (2014-03-13 22:04:09 UTC) #3
nweiz
On 2014/03/13 22:04:09, Bob Nystrom wrote: > On 2014/03/13 22:03:53, Bob Nystrom wrote: > > ...
6 years, 9 months ago (2014-03-13 23:25:41 UTC) #4
nweiz
6 years, 9 months ago (2014-03-13 23:26:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r33673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698