Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 199413020: Fixes code_transformers after the latest analyzer changes (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes code_transformers after the latest analyzer changes BUG=http://dartbug.com/17502 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=33768

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -32 lines) Patch
M pkg/code_transformers/lib/src/resolver_impl.dart View 1 7 chunks +46 lines, -26 lines 0 comments Download
M pkg/code_transformers/lib/src/test_harness.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/code_transformers/test/resolver_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
The resolver no longer supports parsing the code while loading the rest asynchronously, so I ...
6 years, 9 months ago (2014-03-15 01:04:49 UTC) #1
blois
https://codereview.chromium.org/199413020/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart File pkg/code_transformers/lib/src/resolver_impl.dart (right): https://codereview.chromium.org/199413020/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart#newcode579 pkg/code_transformers/lib/src/resolver_impl.dart:579: CompilationUnit _parseCompilationUnit(String code) { Should be able to use ...
6 years, 9 months ago (2014-03-17 16:29:46 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/199413020/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart File pkg/code_transformers/lib/src/resolver_impl.dart (right): https://codereview.chromium.org/199413020/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart#newcode579 pkg/code_transformers/lib/src/resolver_impl.dart:579: CompilationUnit _parseCompilationUnit(String code) { On 2014/03/17 16:29:46, blois wrote: ...
6 years, 9 months ago (2014-03-17 17:58:09 UTC) #3
blois
lgtm
6 years, 9 months ago (2014-03-17 19:07:31 UTC) #4
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-17 20:05:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r33768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698