Issue 19941002: Remove dart:codec and move classes into dart:convert.

Issue 19941002: Remove dart:codec and move classes into dart:convert. (Closed)

Created:
7 years, 5 months ago by floitsch

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, Ivan Posva, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove dart:codec and move classes into dart:convert. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25267

Patch Set 4 : Address comments. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -413 lines)			Patch
M	runtime/vm/bootstrap.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/bootstrap.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object_store.h	View		4 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/vm.gypi	View		4 chunks	+0 lines, -43 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	sdk/lib/codec/codec.dart	View		1 chunk	+0 lines, -107 lines	0 comments	Download
D	sdk/lib/codec/codec_sources.gypi	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	sdk/lib/codec/encoding.dart	View		1 chunk	+0 lines, -60 lines	0 comments	Download
D	sdk/lib/codec/json.dart	View		1 chunk	+0 lines, -51 lines	0 comments	Download
A +	sdk/lib/convert/codec.dart	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	sdk/lib/convert/convert.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/convert/convert_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	sdk/lib/convert/encoding.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	sdk/lib/convert/json.dart	View	1 2 3	1 chunk	+50 lines, -0 lines	0 comments	Download
M	sdk/lib/convert/utf.dart	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
D	tests/lib/codec/codec1_test.dart	View		1 chunk	+0 lines, -70 lines	0 comments	Download
D	tests/lib/codec/codec2_test.dart	View		1 chunk	+0 lines, -42 lines	0 comments	Download
A +	tests/lib/convert/codec1_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	tests/lib/convert/codec2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/utf82_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/convert/utf83_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/create_sdk.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Python uses Codec for similar classes, so we will keep the name for the class. ...

7 years, 5 months ago (2013-07-22 11:37:52 UTC) #1

Søren Gjesse

lgtm https://codereview.chromium.org/19941002/diff/5001/sdk/lib/convert/json.dart File sdk/lib/convert/json.dart (right): https://codereview.chromium.org/19941002/diff/5001/sdk/lib/convert/json.dart#newcode31 sdk/lib/convert/json.dart:31: * object or list property parsed. Repeat the ...

7 years, 5 months ago (2013-07-22 12:04:41 UTC) #2

floitsch

https://codereview.chromium.org/19941002/diff/5001/sdk/lib/convert/json.dart File sdk/lib/convert/json.dart (right): https://codereview.chromium.org/19941002/diff/5001/sdk/lib/convert/json.dart#newcode31 sdk/lib/convert/json.dart:31: * object or list property parsed. On 2013/07/22 12:04:42, ...

7 years, 5 months ago (2013-07-22 12:24:58 UTC) #3

floitsch

7 years, 5 months ago (2013-07-22 12:25:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r25267 (presubmit successful).

Expand Messages | Collapse Messages