Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 19939004: Use window.location.href in path under dart2js. (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Use window.location.href in path under dart2js. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -74 lines) Patch
M pkg/path/lib/path.dart View 2 chunks +6 lines, -14 lines 0 comments Download
A + pkg/path/test/browser_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/path/test/dart2js_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/path/test/dartium_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M pkg/pkg.status View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 5 months ago (2013-07-22 20:27:59 UTC) #1
Bob Nystrom
LGTM. Woo!
7 years, 5 months ago (2013-07-22 21:04:29 UTC) #2
nweiz
7 years, 5 months ago (2013-07-22 21:06:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698