Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1992863002: Check for documented getters when checking setters (#237). (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check for documented getters when checking setters (#237). Update `public_member_api_docs` to follow dartdoc when verifying property accessor docs. Fixes: https://github.com/dart-lang/linter/issues/237 BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/linter/commit/199e981f1a30b69812466ab33510b655dd2180ad

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -20 lines) Patch
M lib/src/rules/public_member_api_docs.dart View 6 chunks +105 lines, -20 lines 1 comment Download
M test/rules/public_member_api_docs.dart View 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-18 17:19:49 UTC) #2
pquitslund
https://codereview.chromium.org/1992863002/diff/1/lib/src/rules/public_member_api_docs.dart File lib/src/rules/public_member_api_docs.dart (right): https://codereview.chromium.org/1992863002/diff/1/lib/src/rules/public_member_api_docs.dart#newcode178 lib/src/rules/public_member_api_docs.dart:178: Map<String, FunctionDeclaration> setters = <String, FunctionDeclaration>{}; Note that I ...
4 years, 7 months ago (2016-05-18 17:21:16 UTC) #3
scheglov
lgtm
4 years, 7 months ago (2016-05-18 17:37:35 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as 199e981f1a30b69812466ab33510b655dd2180ad (presubmit successful).
4 years, 7 months ago (2016-05-18 17:38:12 UTC) #6
Brian Wilkerson
4 years, 7 months ago (2016-05-20 13:56:09 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698