Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1992693003: Linter version 0.1.17. (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
Reviewers:
scheglov, Alexei Diaz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Linter version 0.1.17. Introduces: * Fix to `public_member_api_docs` to check for documented getters when checking setters (#237). * New `iterable_contains_unrelated_type` lint to detect when `Iterable.contains` is invoked with an object of an unrelated type. * New `comment_references` lint to ensure identifiers referenced in docs are in scope (#240). BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/linter/commit/8e1873ba689fbb0064cbd27c238c898106938dcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-18 18:09:03 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-18 18:21:46 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as 8e1873ba689fbb0064cbd27c238c898106938dcd (presubmit successful).
4 years, 7 months ago (2016-05-18 18:24:11 UTC) #5
Alexei Diaz
4 years, 7 months ago (2016-05-19 05:06:47 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698