Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1991303002: Hide some names from package:collection. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Hide some names from package:collection. This prepares for https://codereview.chromium.org/1994743003/, which moves some of these functions into the collection package. Once that lands, we'll add a follow-up CL to use those APIs from collection. R=jakemac@google.com Committed: https://github.com/dart-lang/test/commit/f022729f3b24209b798d8fe324dd55e73f238607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 7 months ago (2016-05-19 19:06:42 UTC) #1
jakemac
lgtm
4 years, 7 months ago (2016-05-19 19:07:30 UTC) #2
nweiz
4 years, 7 months ago (2016-05-19 19:14:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f022729f3b24209b798d8fe324dd55e73f238607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698