Issue 1991283003: Fix `overriden_field` false positive (#246).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1991283003: Fix `overriden_field` false positive (#246). (Closed)

Created:
4 years, 7 months ago by pquitslund

Modified:
4 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/linter.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix `overriden_field` false positive (#246). Fixes: https://github.com/dart-lang/linter/issues/246 Net-net: we need to ensure that the overridden field is in the same library as the overrider. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/linter/commit/8fa9dddfbc96c84ca4eb918e28c74f2e7b428e70

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -1 line)			Patch
M	lib/src/rules/overriden_field.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	test/_data/overridden_field/lintconfig.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	test/_data/overridden_field/src/a.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	test/_data/overridden_field/src/b.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/integration_test.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

4 years, 7 months ago (2016-05-19 21:33:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8fa9dddfbc96c84ca4eb918e28c74f2e7b428e70 (presubmit successful).