Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199003005: Package-ify Dromaeo and browser controller functionality (Closed)

Created:
6 years, 9 months ago by Emily Fortuna
Modified:
6 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Package-ify Dromaeo and browser controller functionality R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=33670

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -28203 lines) Patch
D samples/third_party/dromaeo/Dromaeo.dart View 1 2 3 1 chunk +0 lines, -230 lines 0 comments Download
D samples/third_party/dromaeo/LICENSE View 1 2 3 1 chunk +0 lines, -30 lines 0 comments Download
D samples/third_party/dromaeo/README View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
D samples/third_party/dromaeo/Suites.dart View 1 2 3 1 chunk +0 lines, -174 lines 0 comments Download
D samples/third_party/dromaeo/application.css View 1 2 3 1 chunk +0 lines, -115 lines 0 comments Download
D samples/third_party/dromaeo/common/BenchUtil.dart View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D samples/third_party/dromaeo/common/Interval.dart View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D samples/third_party/dromaeo/common/Math2.dart View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D samples/third_party/dromaeo/common/common.dart View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
D samples/third_party/dromaeo/dromaeo_end_condition.js View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
D samples/third_party/dromaeo/favicon.ico View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/favicon.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/generate_perf_and_dart2js_tests.py View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
D samples/third_party/dromaeo/htmlrunner.js View 1 2 3 1 chunk +0 lines, -142 lines 0 comments Download
D samples/third_party/dromaeo/images/bg.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/clouds.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/clouds2.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/comets.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino1.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino2.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino3.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino4.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino5.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino6.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino7.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/dino8.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/left.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/logo.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/logo2.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/logo3.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/right.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/top.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/images/water.png View 1 2 3 Binary file 0 comments Download
D samples/third_party/dromaeo/index.html View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
A samples/third_party/dromaeo/lib/transformer.dart View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A samples/third_party/dromaeo/pubspec.yaml View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
D samples/third_party/dromaeo/reset.css View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
D samples/third_party/dromaeo/test-head.html View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D samples/third_party/dromaeo/test-tail.html View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D samples/third_party/dromaeo/tests/Common.dart View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D samples/third_party/dromaeo/tests/RunnerSuite.dart View 1 2 3 1 chunk +0 lines, -132 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-attr.html View 1 2 3 1 chunk +0 lines, -2946 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-attr-html.dart View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-attr-html.html View 1 2 3 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify.html View 1 2 3 1 chunk +0 lines, -2973 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify-html.dart View 1 2 3 1 chunk +0 lines, -72 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify-html.html View 1 2 3 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query.html View 1 2 3 1 chunk +0 lines, -3000 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query-html.dart View 1 2 3 1 chunk +0 lines, -106 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query-html.html View 1 2 3 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse.html View 1 2 3 1 chunk +0 lines, -2972 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse-html.dart View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse-html.html View 1 2 3 1 chunk +0 lines, -2900 lines 0 comments Download
samples/third_party/dromaeo/tests/dom-traverse-html.html View 1 2 3 1 chunk +0 lines, -2900 lines 0 comments Download
samples/third_party/dromaeo/web-style.css View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
D samples/third_party/dromaeo/web-style.css View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
A + samples/third_party/dromaeo/web/Dromaeo.dart View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
A + samples/third_party/dromaeo/web/LICENSE View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/README View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/Suites.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/third_party/dromaeo/web/application.css View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/common/BenchUtil.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/common/Interval.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/common/Math2.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/common/common.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/favicon.ico View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/favicon.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/htmlrunner.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
samples/third_party/dromaeo/web/images/bg.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/images/bg.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/clouds.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/clouds2.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/comets.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino1.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino2.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino3.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino4.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino5.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino6.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino7.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/dino8.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/left.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/logo.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/logo2.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/logo3.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/right.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/top.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/images/water.png View 1 2 3 Binary file 0 comments Download
A + samples/third_party/dromaeo/web/index.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + samples/third_party/dromaeo/web/reset.css View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/test-head.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/test-tail.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/Common.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/RunnerSuite.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-attr.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-attr-html.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-attr-html.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-modify.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-modify-html.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-modify-html.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-query.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-query-html.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-query-html.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-traverse.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-traverse-html.dart View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/tests/dom-traverse-html.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/third_party/dromaeo/web/web-style.css View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/html/dromaeo_smoke_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D tools/testing/dart/browser_perf_testing/lib/browser_perf_testing.dart View 1 2 3 1 chunk +0 lines, -146 lines 0 comments Download
D tools/testing/dart/perf_test_controller.js View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M tools/testing/perf_testing/run_perf_tests.py View 1 2 3 3 chunks +20 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
This CL looks bigger than it actually is. Most of it is just rearranging the ...
6 years, 9 months ago (2014-03-13 18:32:07 UTC) #1
vsm
lgtm https://chromiumcodereview.appspot.com/199003005/diff/130001/samples/third_party/dromaeo/pubspec.yaml File samples/third_party/dromaeo/pubspec.yaml (right): https://chromiumcodereview.appspot.com/199003005/diff/130001/samples/third_party/dromaeo/pubspec.yaml#newcode9 samples/third_party/dromaeo/pubspec.yaml:9: path: ../../../../../github/browser_controller Is this a path in the ...
6 years, 9 months ago (2014-03-13 22:02:20 UTC) #2
Emily Fortuna
https://chromiumcodereview.appspot.com/199003005/diff/130001/samples/third_party/dromaeo/pubspec.yaml File samples/third_party/dromaeo/pubspec.yaml (right): https://chromiumcodereview.appspot.com/199003005/diff/130001/samples/third_party/dromaeo/pubspec.yaml#newcode9 samples/third_party/dromaeo/pubspec.yaml:9: path: ../../../../../github/browser_controller On 2014/03/13 22:02:21, vsm wrote: > Is ...
6 years, 9 months ago (2014-03-13 22:43:06 UTC) #3
Emily Fortuna
6 years, 9 months ago (2014-03-13 22:44:56 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as r33670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698